Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_search_service - Add support for allowed_ips #8557

Merged
merged 3 commits into from
Sep 22, 2020
Merged

azurerm_search_service - Add support for allowed_ips #8557

merged 3 commits into from
Sep 22, 2020

Conversation

mbfrahry
Copy link
Member 

--- PASS: TestAccAzureRMSearchService_basic (84.53s)
--- PASS: TestAccAzureRMSearchService_requiresImport (89.07s)
--- PASS: TestAccAzureRMSearchService_update (1621.21s)
--- PASS: TestAccAzureRMSearchService_ipRules (1168.95s)

katbyte
katbyte approved these changes Sep 22, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a couple comments LGMT 👍

azurerm/internal/services/search/tests/resource_arm_search_service_test.go Outdated
}

resource "azurerm_resource_group" "test" {
name = "acctestRG-%d"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "acctestRG-%d"
name = "acctestRG-search-%d"

website/docs/r/search_service.html.markdown Outdated
@@ -52,6 +52,8 @@ The following arguments are supported:

-> **Note:** `partition_count` and `replica_count` can only be configured when using a `standard` sku.

* `ip_rules` - (Optional) A list of IP addresses that are allowed access to the search service endpoint.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have an example of whats expected? eg 10.0.0.1 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have some restrictions with loop/local addresses so I'd have to put some random IP there which doesn't feel great. I'll just update that it's a list of ipv4 addresses and we can update it further if there is confusion.

azurerm/internal/services/search/resource_arm_search_service.go Outdated
@@ -108,6 +109,15 @@ func resourceArmSearchService() *schema.Resource {
Default: true,
},

"ip_rules": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this be better as

Suggested change
"ip_rules": {
"allowed_ips": {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@mbfrahry mbfrahry changed the title azurerm_search_service - Add support for ip_rules azurerm_search_service - Add support for allowed_ips Sep 22, 2020
@mbfrahry mbfrahry merged commit c53887f into master Sep 22, 2020
@mbfrahry mbfrahry deleted the f-search-service-ip branch September 22, 2020 06:23
mbfrahry added a commit that referenced this pull request Sep 22, 2020
@mbfrahry
Update changelog for #8557
02217fd
@ghost
Copy link

ghost commented Oct 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbfrahry @katbyte